-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: use validateObject
#39595
Closed
Closed
lib: use validateObject
#39595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used the `validateObject()` validator to keep consistency instead of a custom validator which was only used to validate objects.
nodejs-github-bot
added
encoding
Issues and PRs related to the TextEncoder and TextDecoder APIs.
needs-ci
PRs that need a full CI run.
labels
Jul 30, 2021
RaisinTen
reviewed
Jul 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes behavior as the parameter options
cannot be null
or an array, which was possible before. Should we also pass { nullable: true, allowArray: true }
as a third argument to validateObject()
?
Used the `validateObject()` validator to keep consistency instead of a custom validator which was only used to validate objects.
It seems like something went wrong here, re-opening with a different PR. |
VoltrexKeyva
added a commit
to VoltrexKeyva/node
that referenced
this pull request
Jul 31, 2021
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: nodejs#39595
VoltrexKeyva
added a commit
to VoltrexKeyva/node
that referenced
this pull request
Jul 31, 2021
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: nodejs#39595
VoltrexKeyva
added a commit
to VoltrexKeyva/node
that referenced
this pull request
Jul 31, 2021
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: nodejs#39595
jasnell
pushed a commit
that referenced
this pull request
Aug 12, 2021
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: #39595 PR-URL: #39605 Refs: #39595 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: #39595 PR-URL: #39605 Refs: #39595 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: #39595 PR-URL: #39605 Refs: #39595 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the
validateObject()
validator to keep consistency instead of acustom validator which was only used to validate objects.